[PEPr] +1 for System::System_Mount
| From: | PEPr | Date: | Sat, 29 May 2004 04:33:38 +0000 |
| Subject: | [PEPr] +1 for System::System_Mount | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-29784@lists.php.net to get a copy of this message | ||
Daniel Convissor (http://pear.php.net/user/danielc) has voted +1 on the proposal for
System::System_Mount.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=67
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=67&handle=danielc
This vote is conditional. The condition is:
Nice job. Clean code.
Two quick comments on the docblocks.
In the var declarations, use "@var" instead of "@type." I don't think
@type is valid, at least it isn't in phpDocumentor's documentation.
The code says the PHP License is being used but then you have
"@copyright Copyright © 2004, Ian Eure." Is that left over from prior
incarnations? I mean, either you're using the PHP License or not.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net