Re: [PEPr] +1 for System::System_Mount

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Friday 28 May 2004 09:33 pm, PEPr wrote: > Daniel Convissor (http://pear.php.net/user/danielc) has voted +1 on the > proposal for System::System_Mount. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=67 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=67&handle=danielc > > This vote is conditional. The condition is: > > Nice job. Clean code. > > Two quick comments on the docblocks. > > In the var declarations, use "@var" instead of "@type." I don't think > @type is valid, at least it isn't in phpDocumentor's documentation. > Fixed in my CVS. > The code says the PHP License is being used but then you have > "@copyright Copyright © 2004, Ian Eure." Is that left over from prior > incarnations? I mean, either you're using the PHP License or not. > I think that you're confused. As the creator of the code, I own the copyright unless I sign it over. There is no conflict between saying that I own the copyright and releasing the code under the PHP license, or any other that I choose. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFAuBbaxuUdPD6j2IMRAkXpAKC+Vp70ohYgVAg+5U8+yci3wpV2zgCfan7H DfV1E/K2NvFanYg1XjHOUUQ= =gZws -----END PGP SIGNATURE-----