Final RFC for Net_SMPP/Net_SMPP_Client
| From: | Ian Eure | Date: | Mon, 18 Jul 2005 22:46:08 +0000 |
| Subject: | Final RFC for Net_SMPP/Net_SMPP_Client | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-38706@lists.php.net to get a copy of this message | ||
So far as I know, all the issues that were raised regarding
Net_SMPP/Net_SMPP_Client have been addressed, save one.
That issue is the naming/structure convention for the PDU classes. The
commands in my implementation are named identically to how they are specified
in the SMPP v3.4 specification, which is to say they contain underscores. For
example, the class for the PDU to send a SMS is 'submit_sm,' it's located in
Net/SMPP/Command/submit_sm.php, and the class is called
Net_SMPP_Command_submit_sm.
Standard PEAR practice is that underscores are replaced with slashes to build
the directory structure. However. this is /not/ mentioned in the PEAR CS. I
used this slightly unusual setup so the class would conform to the SMPP
specification; the thought being that the primary document you'd need to read
is the SMPP specification, instead of weird APIs in Net_SMPP which don't
conform to spec.
Thoughts? Other issues? I'd like to get this officially proposed in PEPr soon.
Attachment: [application/pgp-signature]
Attachment: [application/pgp-signature]