Re: Re: Final RFC for Net_SMPP/Net_SMPP_Client

On Monday 18 July 2005 03:56 pm, Pierre-Alain Joye wrote: > On Mon, 18 Jul 2005 15:46:08 -0700 > > ieure@php.net (Ian Eure) wrote: > > Standard PEAR practice is that underscores are replaced with > > slashes to build the directory structure. However. this is /not/ > > mentioned in the PEAR CS. I used this slightly unusual setup so > > the class would conform to the SMPP specification; the thought > > being that the primary document you'd need to read is the SMPP > > specification, instead of weird APIs in Net_SMPP which don't > > conform to spec. > > This is in the manual, arguing about that is more or like nuts :) > Could you provide a citation? It's definitely not in the CS, which is where I would expect it to be. It's also not in the Developer Guide or New Maintainers' Guide. > > Thoughts? Other issues? I'd like to get this officially proposed > > in PEPr soon. > > For the APIs, no idea (did not see or read yours), but the class > names to path mapping is not going to be removed for your package. > Have you a link to the specs? I doubt they specified a OO class > model besides some std API names. > The link to the SMPP specification is: http://smsforum.net/doc/download.php?id=smppv34 (you need to provide an email address to download) Whether or not they specified an OO model is not relevant. > For the code itself, once it's a pepr or you provide a link to the > the sources, I will comment. > It's already there, I just haven't called for votes yet. Net_SMPP: http://pear.php.net/pepr/pepr-proposal-show.php?id=239 Net_SMPP_Client: http://pear.php.net/pepr/pepr-proposal-show.php?id=240

Attachment: [application/pgp-signature]