Re: Re: Final RFC for Net_SMPP/Net_SMPP_Client

On Tuesday 19 July 2005 02:18 pm, Pierre-Alain Joye wrote: > http://pear.php.net/manual/en/standards.naming.php > "The PEAR class hierarchy is also reflected in the class name, each > level of the hierarchy separated with a single underscore." > > Can it be more clear? > Yes, it can. "PEAR hierarchy" is not defined, and it's not clear if that means "the category/subcategory structure" or "absolutely every file in a PEAR installation." > > Whether or not they specified an OO model is not relevant. > > It is as you stated that our APIs (class names in this case) are > weird and do not conform to spec. > So you advocate making a project harder to use because it's internal structure (which should never be used directly) doesn't match the PEAR conventions? That seems like a pretty bad trade-off to me. Can someone else please weigh in on this? I'd really like this point resolved before I call for votes. I know it's unusual for PEAR packages to have files with underscores in them, but I think it's really the right thing to do in this case. It's not unknown in PEAR, either: - I18Nv2: I18Nv2/Locale/*.php use underscores to match locale names. - PHP_Compat: Lots of files in PHP/Compat/Function/ also use underscores in file names without creating a directory structure. - Log: Log/error_log.php - Var_Dump: Main package file is Var_Dump.php, not Var/Dump.php. Renderers also contain underscores. - XML_XSLT_Wrapper: Several files in XML/XSLT/Wrapper/Backend/. - HTML_Template_IT: HTML/Template/IT_Error.php In both the I18Nv2 and PHP_Compat instances, they do this for the exact reasons I want to: they're matching up with an external specification which uses underscores in names, instead of to indicate structure. Furthermore, I note that you are the lead developer of both HTML_Template_IT and XML_XSLT_Wrapper. I fail to see how you can argue that this is bad when I do it, yet perfectly fine when you do.

Attachment: [application/pgp-signature]