[PEPr] Comment on Authentication::OpenID

Demian Turner (http://pear.php.net/user/demianturner) has commented on the proposal for Authentication::OpenID. Comment: Hey JanRain, Nice package, much needed by the PHP community. Good work also on commenting and coding style. After a quick glance I can see a few very small issues: - please use require_once "Auth/OpenID/OIDUtil.php"; instead of require_once("Auth/OpenID/OIDUtil.php"); - please use package namespaced constants instead of globals, ie Auth_OpenID_SUCCESS instead of $Auth_OpenID_SUCCESS = 'success'; - avoid the use of globals whenever possible, security risk and bad programming style - use PEAR errors instead of trigger_error("blah") - perhaps consider using HTTP_Request for your fetcher stuff to avoid unnecessary code cheers Demian Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=347 -- Sent by PEPr, the automatic proposal system at http://pear.php.net