Re: [PEPr] Call for votes on Authentication::OpenID

Jonathan Daugherty wrote:

Putting these functions in a class gets us nothing but an extra layer of namespace that we don't need, and it's a misrepresentation of the purpose of those functions. I realize that this may be a personal style conflict, but I'm going to defer to the PEAR coding guidelines here: "Functions should in addition have the package name as a prefix, to avoid name collisions between packages."

Turning those functions into methods makes other peoples code more organized and maintainable. You should think about the end user here. Users of PEAR code expect to call Auth_OpenID::arrayGet() not Auth_OpenID_array_get() (note that array_get() is against the PCS). I think you should refer to this section of the PEAR docs: http://pear.php.net/manual/en/developers.meaning.php The coding standards don't support your argument for using functions. They just support your argument for the names you have chosen (well, in one case anyway). -- Scott Mattocks http://www.crisscott.com