Re: [PEPr] Call for votes on Authentication::OpenID
| From: | Jonathan Daugherty | Date: | Wed, 08 Feb 2006 20:03:05 +0000 |
| Subject: | Re: [PEPr] Call for votes on Authentication::OpenID | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41247@lists.php.net to get a copy of this message | ||
# I can see lots of global functions and variables... you should wrap
# them inside a full qualified class.
I realize the dangers of global variables and it's understandable
that most people see them and react violently. I can assure you that
we reserved global variables for situations where they made sense. As
for the functions, they're already namespaced according to the PEAR
guidelines.
# Also, things like require_once 'Utils.php'; should be require_once
# 'Auth/OpenID/Utils.php'; or something like that.
Thanks. I've been meaning to make the require lines consistent.