[PEPr] +1 for Authentication::OpenID
| From: | Markus Tacker | Date: | Thu, 09 Feb 2006 09:22:16 +0000 |
| Subject: | [PEPr] +1 for Authentication::OpenID | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41266@lists.php.net to get a copy of this message | ||
Markus Tacker (http://pear.php.net/user/tacker) has voted +1 on the proposal for
Authentication::OpenID.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=347
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=347&handle=tacker
This vote is conditional. The condition is:
I like this package very much, but my vote depends on
* Implementing functions as methods
* Implementing global vars as properties
* Changing the file layout to reflect the class names (e.g. Auth_OpenID_Consumer should be in
Auth/OpenID/Consumer.php not in Auth/OpenID/Consumer/Consumer.php)
* Using PEAR_Error in favour of trigger_error
* Let every class have its own file
* Documentation of private methods
Fix or circumvent these errors
* PHP Fatal error: Call to undefined function posix_getpwuid() in PHP-OpenID/examples/detect.php
on line 327
Thumbs up for the good documentation on public methods and your effort to contribute this package.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net