Re: [PEPr] Call for votes on Authentication::OpenID
| From: | Jonathan Daugherty | Date: | Wed, 08 Feb 2006 21:05:59 +0000 |
| Subject: | Re: [PEPr] Call for votes on Authentication::OpenID | ||
| References: | 1 2 3 4 5 6 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41253@lists.php.net to get a copy of this message | ||
> Turning those functions into methods makes other peoples code more
> organized and maintainable. You should think about the end user here.
I agree, and anything that we expect end-users to use is certainly
organized with their code quality in mind.
> The coding standards don't support your argument for using functions.
The coding standards do not forbid the declaration of functions that
aren't in a class, and that is all I'm really asserting. Whether the
names of our functions violate another aspect of the guide is a separate
issue. I'll gladly do a scan of the code to fix underscore usage in
functions; this is an API port and I'm sure we missed a few.
--
Jonathan Daugherty
JanRain, Inc.