Re: cvs: phpdoc / Makefile.in

From: Date: Fri, 16 May 2003 16:02:21 +0000
Subject: Re: cvs: phpdoc / Makefile.in
References: 1  Groups: php.doc 
Request: Send a blank email to phpdoc+get-969353537@lists.php.net to get a copy of this message
I have found a few bugs even in the English XSL builds. I have fixed some of them on my local machine, but I have not had time to correct them all.
First of all these are not significant problems, so you can go to your weekend and when you'll be back, and have time to test all things out, then the changes can be committed. It would not be good to commit untested changes now when the fist xsl builds are going on.
Some of them are mostly formatting (such as extra whitespace inside examples and not bolding function names), but there are a few more significant problems. 1) We don't reset the Example numbering for each function name. (I fixed this.)
We agreed that this is not a problem, maybe even an advantage. One can refer to a specific example number (but it will change with every build, so this should not be relied on). As far as I can see it is not our main focus to make the XSL output exactly the same as the DSSSL one. Anytime we can improve things, we'd better to that. This was considered to be sort of an improvement.
2) Navigation links aren't always correctly generated. See, for example, the sidebar of features.safe-mode.functions.php. The DSSSL page has a link to "Security and Safe Mode," while the XSL generated page does not. I believe this has to do with us putting multiple chunks in a single document and our query to generate the "toc" array, but I haven't had time to look at this in more detail.
Well, this is probably a problem and would be nice to fix.
PS: I have also been doing some profiling using xsltproc and one particular XPATH query seems to use about 10% of the time. Once we manage to get the XSL build working properly, I will be able to devote some additional time to optimizing performance.
This would be cool. Goba

« previous php.doc (#969353537) next »