Re: Image_Text mess in CVS
| From: | Stefan Neufeind | Date: | Wed, 12 Nov 2003 09:57:33 +0000 |
| Subject: | Re: Image_Text mess in CVS | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-23492@lists.php.net to get a copy of this message | ||
On 12 Nov 2003 at 10:47, Bertrand Mansion wrote:
> Could the QA team (do we have a QA team BTW ?) have a look at the mess
> in CVS with Image_Text and try to fix that ? Or would Tobias be nice
> enough to look at other packages in CVS and try to do the same when
> committing, and not invent its own way. Thanks,
Well, I guess I know what you're talking about :-) Toby announced the
"new way" of handling files in CVS on his private blog - and although
I didn't fully agree with the way he did it at least I understood why
he did it. I don't know how other people on the list handle these
"problems" - but have wondered how to do it "better" myself:
The problem is that when you develop in CVS (and on your harddisk) in
a file-structure like:
Image_Text/Image_Text.php
Image_Text/docs/example.php
[... other files as well - it's just for explanation ...]
and in example.php you do a
require_once 'Image/Image_Text.php';
then you run into problems because you can't test your example with
the current file-structure you have. Toby's idea (not that I think
it's brilliant - but it solves the problem) to get out of this
problems is:
Image_Text/Image/Image_Text.php
Image_Text/Image/docs/example.php
Now he can include Image_Text/ into his include-path - and can work
with 'Image/Image_Text.php' etc. rightaway.
For sure there must be a better solution than that. But I don't know
how to solve it more elegant.
Another thing I'd like to mention again in this discussion:
Since the main package file resides under Image/ shouldn't it be
named Image/Text.php instead of Image/Image_Text.php? But I believe
this is probably a general issue with package names and files inside
the package. A rule how to do it "correctly" would be nice.
If we come up with correct ways for handling files in CVS / on
harddisk and about the filenames I'd volunteer to have a look at the
current package to try to help solve some inconsistencies with the
where possible. (Background: You can't move / rename files in CVS
without loosing CVS-history for that file - so renaming / moving
should be done directly on the server via SSH).
Regards,
Stefan