Re: [PEPr] +1 for XML::XML_RPC2 (reproposal)

Bertrand Mansion wrote: > Bertrand Mansion (http://pear.php.net/user/mansion) has voted +1 on the proposal for > XML::XML_RPC2 (reproposal). > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=259 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=259&handle=mansion > > Comment: > > XML_RPC2_Backend_Php_Response::encode() > > XML_RPC2_Backend_Php_Response::encodeFault() > > Please get rid of short php tags (<?=) which might not be supported by > everyone. Also, it might be cleaner to get rid of ob_ functions in > general. I can easily get rid of short tags, but output buffering isn't so simple. If ob is that uncommon, I guess I can use heredoc syntax, but the code loses a bit on readability. > Please implement a new HTTPRequest object that does not depend on cURL. The current HTTPRequest is a slimmed down, API-compatible, HTTP_Request. The objective is to use the HTTP_Request package once it becomes E_STRICT compliant. I'd gladly port, or help to port, HTTP_Request to PHP5. That is, however, a task outside the scope of this package. > Try to always put the { below the method name. You forgot to do so in a > few places. I'll do a second pass at that. That one counter-CG habbit is hard to lose. > Thanks, the rest of your code is ok for me. Thanks for the thorough review. Cheers, -- Sérgio Carvalho