[PEPr] +1 for XML::XML_RPC2 (reproposal)
| From: | Bertrand Mansion | Date: | Thu, 30 Jun 2005 06:26:39 +0000 |
| Subject: | [PEPr] +1 for XML::XML_RPC2 (reproposal) | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-38383@lists.php.net to get a copy of this message | ||
Bertrand Mansion (http://pear.php.net/user/mansion) has voted +1 on the proposal for XML::XML_RPC2
(reproposal).
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=259
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=259&handle=mansion
Comment:
XML_RPC2_Backend_Php_Response::encode()
XML_RPC2_Backend_Php_Response::encodeFault()
Please get rid of short php tags (<?=) which might not be supported by
everyone. Also, it might be cleaner to get rid of ob_ functions in
general.
Please implement a new HTTPRequest object that does not depend on cURL.
Getting rid of {{ and }} stuff in your comments might make your code
easier to read, at least for non-vim users... But that's up to you.
Try to always put the { below the method name. You forgot to do so in a
few places.
Thanks, the rest of your code is ok for me.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net