Re: [RFC] Typed Properties

Den 2018-07-07 kl. 23:12, skrev Zeev Suraski:

-----Original Message----- From:php@golemon.com [mailto:php@golemon.com] On Behalf Of Sara Golemon Sent: Friday, July 6, 2018 10:36 PM To: Christoph M. Becker<cmbecker69@gmx.de> Cc: Nikita Popov<nikita.ppv@gmail.com>;stas@php.net; Björn Larsson <bjorn.x.larsson@telia.com>; Dan Ackroyd<danack@basereality.com>; Stanislav Malyshev<smalyshev@gmail.com>; Marco Pivetta <ocramius@gmail.com>; PHP internals<internals@lists.php.net> Subject: Re: [PHP-DEV] [RFC] Typed Properties Just want to be annoying about this since the currently scheduled fork date for PHP-7.3 is 11 days off. 1/ Do we have *ANY* objections to additional alpha(s) to accommodate Typed Props? (I would propose two additional alphas) 2/ Do we actually need to hold a formal vote? (If so, that vote should start *now*)

Sara, I do see a couple of issues here. First, it may be a personal thing, but I feel that the flexibility towards adding this is very contrasty with the inflexibility shown as we headed towards the PHP 7.0 feature freeze - inflexibility that resulted in a rushed (and IMHO wrong) decision regarding how to implement the non-strict types. For the record - as I said back then - I think that the right way is to be flexible - the dates are just dates, and are - in all honesty - not that important - it’s the severe inconsistency that bothers me. Secondly, and somewhat related - typed properties isn't a small feature. It is, in fact, a pretty huge one. Making exceptions for a fairly minor feature or some extra deprecation is one thing. Making an exception for something as fundamental as that feels wrong. Even though Nikita's proposal and implementation look pretty solid, something as fundamental as that should go through a substantial active discussion period (which didn't really happen here as it wasn't clear whether this was headed for an exceptional 7.3 addition or not) - and independently - should perhaps go hand-in-hand with fixing the flaws of the non-strict types - something we can do in PHP 8. If we do the latter, then perhaps, just perhaps, we can introduce it hand-in-hand with typed variables - and if we do, it will be sensible to do it at the same time and not in a gradual rollout. Personally, I think even independently of typed variables, typed properties feel like an 8.0 feature, not a 7.x feature. Zeev You do have a point here about combining this with 8.0. I think it

then would be great if an RFC like the one for 7.0 shows up soon. - https://wiki.php.net/rfc/php7timeline If 8.0 drags on I think it's beneficial to have this feature earlier, like now ;-) I was a bit surprised myself that the discussion has not been so active. On the other hand typed properties was up for discussion earlier and much of the disadvantages has now been remedied in this proposal. Given the high quality of this RFC and earlier discussions I personally felt it was not so much to ponder about. I can see some advantages with having this feature in a 7.x release: - It leaves more space for doing other stuff in 8.0 given that core   resources are scarce. - It adds a lot of value to 7.3, which is not packed with features. r//Björn Larsson