[PEPr] -1 for File Formats::File_CSV_Get
| From: | Brett Bieber | Date: | Thu, 11 Dec 2008 14:31:31 +0000 |
| Subject: | [PEPr] -1 for File Formats::File_CSV_Get | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-51285@lists.php.net to get a copy of this message | ||
Brett Bieber (http://pear.php.net/user/saltybeagle) has voted -1 on the proposal for File
Formats::File_CSV_Get.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=577
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=577&handle=saltybeagle
Comment:
I feel the method naming is still too inconsistent and un-obvious.
I think uses() should be load, fopen, or open. The coordinatable method
should be something like cellExists(), hasCell() etc.
The parse() function simply loads everything into an array... how will
this handle large files? The _patch() method functions similarly by using a
simple file_get_contents(...) then runs a preg_replace on the entire file.
I think there's still a lot of work before this package should be
accepted.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net