Re: [PEPr] +1 for File Formats::File_CSV_Get

Thanks all for your valuable votes!

Brett Bieber's Comment: I feel the method naming is still too inconsistent and un-obvious. I think uses() should be load, fopen, or open. The coordinatable method should be something like cellExists(), hasCell() etc. The parse() function simply loads everything into an array... how will this handle large files? The _patch() method functions similarly by using a simple file_get_contents(...) then runs a preg_replace on the entire file. I think there's still a lot of work before this package should be accepted.

There is been some discussion with the naming of the methods I am appending the resolution of those mails below.

Bill Shupp's Comment: I appreciate the amount of documentation and examples. However, I do agree that there are too many inconsistencies with method names. column() should be getColumn(), uses() should be use() or load(), convertable() could be isConvertable(). Any description that starts with "Gets" or "Sets" should have a corresponding prefix in the method name. The documentation certainly clarifies what things do, but the method names should be clearer. Good work!

Thanks and yes!

Mark Wieseman's Comment: I share the opinions about the methods naming scheme. I'm also not sure whether "File_CSV_Get" is the best name for this package (but unfortunately I can't provide a better one at the moment).

package naming is the real challenge! anybody has any ideas on this? ---------- Did you guys see this email?

Thank you everyone for your valuable votes! And for helping making the code better! * +1^ (Christian Weiske) 2008-11-30 10:20 UTC * +1* (Till Klampaeckel) 2008-12-01 14:31 UTC * +1^ (Michael Gauthier) 2008-12-02 02:28 UTC * +1^ (David Jean Louis) 2008-12-02 09:10 UTC * +1 (Chuck Burgess) 2008-12-09 15:34 UTC * +1 (Ken Guest) 2008-12-09 15:38 UTC I made a summary of the things and observations that everybody made I hope we agree on this so I can start making changes! Cheers! Kazuyoshi Tlacaelel. ---------- TODO: ** Method renaming column > getColumn headers > getHeaders row > getRow rows > getRows cell > getCell uses > load (also loadable as an optional argument in the contructor method) // will keep alias rawArray > getRawArray coordinatable > hasCell injectHeaders > setHeaders symmetric > isSymmetric // will keep alias settings > setConfig asymmetry > getAsymmetricRows // will keep alias ** Dropped classes File_CSV_GetSql ** File removal (from package.xml) doc/phpdoc/* misc/output* ** package.xml changes README (change role from "data" to "doc") LICENCE (change role from "data" to "doc") ** README add link to google-code documentation