Re: [PEPr] +1 for File Formats::File_CSV_Get

On Tue, Dec 2, 2008 at 6:10 PM, David Jean Louis <izi@php.net> wrote: > > David Jean Louis (http://pear.php.net/user/izi) has voted +1 on the > proposal for File Formats::File_CSV_Get. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=577 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=577&handle=izi > > This vote is conditional. The condition is: > > I agree with all the remarks concerning method naming, and this also apply > to File_CSV_GetSql. > BTW I'm not sure this class is a good idea, it's beyond the scope of the > package imho (and it seems to be vulnerable to sql injections). > Yeah, that one was on its own package in the beginning, and am still sckeptical about it, that is why it isn't as docuemented as its parent. good observation, and yes is not sql injection secure. I'll drop that class and maybe add it ass another package in the future. > > Please also remove doc/phpdoc and misc/*.output from your package.xml, > these files should not be installed (and README and LICENCE should have > "doc" role instead of "data"). I though we needed to document the package, or is it not the right way to do it? I kind of like that the package ships with compiled documentation though! I also like that peoople can see what is the status of the release by looking a test result logs and stuff, I defenetly feel like removing the phpdoc log! I'm glad you listened to all remarks and made the relevant changes, the > code looks much better now. > Thanks to you guys, you have made a lot of good observations about the code, and helped make it better! Cheers. -- Sent by PEPr, the automatic proposal system at http://pear.php.net