[PEPr] +1 for File Formats::File_CSV_Get
| From: | David Jean Louis | Date: | Tue, 02 Dec 2008 09:10:04 +0000 |
| Subject: | [PEPr] +1 for File Formats::File_CSV_Get | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-51200@lists.php.net to get a copy of this message | ||
David Jean Louis (http://pear.php.net/user/izi) has voted +1 on the proposal for File
Formats::File_CSV_Get.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=577
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=577&handle=izi
This vote is conditional. The condition is:
I agree with all the remarks concerning method naming, and this also apply to File_CSV_GetSql.
BTW I'm not sure this class is a good idea, it's beyond the scope of the package imho (and
it seems to be vulnerable to sql injections).
Please also remove doc/phpdoc and misc/*.output from your package.xml, these files should not be
installed (and README and LICENCE should have "doc" role instead of "data").
I'm glad you listened to all remarks and made the relevant changes, the code looks much better
now.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net