Re: Comments on bugs marked bogus

On 7/26/05, Alexey Borzov <borz_off@cs.msu.su> wrote: > Hi, > > Justin Patrin wrote: > >>If a comment is made on a bug flagged bogus, do the developers get a > >>message? I added a comment to bug > >>http://pear.php.net/bugs/bug.php?id=3197 but I am not > >>sure if anyone > >>will see it. Do I need to re-open the bug first? > > > > Yes, they should see the message even if the bug us set bogus. It > > simply sounds like the maintainer doesn't want to make the change > > although he gives no real reasons for it. I've added a comment fo my > > own as well. > > The maintainer has his reasons. __autoload() from his point of view is bad > voodoo very much like the infamous "magic quotes". Ok, well this is your opinion. The whole class naming scheme is PEAR is meant to allow things like __autoload to easily be done. > It also shouldn't be probably > triggered by using is_a() function which is deprecated (!) in PHP5. Also true. Likely this should be reported to the PHP developers. > So if > someone is bent on using __autoload() Black Magick he should take necessary > precautions. Like only __autoload() his own classes and not touch PEAR's *at > all* (none of them requires __autoload()!). If someone is too lazy to properly > code his functions and understand the consequences, I have *no* sympathy for them. > Now you're just being a dick. Yes, you're right, a user's implementation of __autoload() shouldn't be touching PEAR classes as PEAR classes can load on their own. At least in most cases. Think about sessions for an example. If you store a classes in a session you need to explicitly require all of the functions which are needed for that class before you can use the objects. All of the in-package autoloading does not help here at all. A simple use of __autoload() does, assuming classes are named well (as PEAR classes should). Now think of the bug report. You're using lower case. Switching to proper casing of the class fixes the problem and has no side-effects. True, this is probablu a bug in PHP (it should be doing case-insensitive checks) but PEAR packages have worked around this before. Not to mention that getting a bug fix into main-line PHP takes a long time and sometimes never happens because of answers to bugs like the ones you've posted. I think that you should consider putting in this *no code added* fix as it solves someone's problem and does not change anything about how HTML_QuickForm work, except to workaround this particular problem with PHP. -- Justin Patrin