Re: Comments on bugs marked bogus

Bertrand Mansion wrote:

Alexey has one point with PEAR_Error. This should be fixed first. We also have an HTML_QuickForm_Error object, and like with PEAR, it is bundled in the same file as HTML_QuickForm. __autoload() will force us to use one file per class. IMO, this is silly, especially knowing that the biggest performance issue with PHP AFAIK is related to seeking files. But I don't want to fight windmills. So the question really is whether we want to allow the use of __autoload() with PHP knowing that, like magic_quotes, it is not a good practice, or if we simply don't care. This decision will have consequences on at least 50% of our packages, especially the big ones.

I wrote up a proposal on this a while back or atleast some thoughts in that direction: http://www.manucorp.com/archives/pear-dev/200503/msg00258.php As for the single class per file rule I am hoping we can find a way to come up with a less strict solution. For example in the PEAR_Error case there is a specific method to check if a given instance is a PEAR_Error. Also users will not need to make instances of PEAR_Error without having to load PEAR anyways. So I think this is a good example of where I really dont see a need to break out the class definition into another file. MDB2 also has a few abstract classes. It might also be ok to keep those classes within the main MDB2.php file. regards, Lukas