Re: Comments on bugs marked bogus
| From: | Justin Patrin | Date: | Tue, 26 Jul 2005 21:30:30 +0000 |
| Subject: | Re: Comments on bugs marked bogus | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-38948@lists.php.net to get a copy of this message | ||
On 7/26/05, Alexey Borzov <borz_off@cs.msu.su> wrote:
> Joshua Eichorn wrote:
> > Being in outsider in this just seems like a stupid argument to be having.
> >
> > PHP5 is case sensitive, so we should start using case when calling is_a,
> > etc to be forward compatible. If thats too big of an issue you could
> > just say that quickforms isn't supported under PHP5. Anyhow its a less
> > then one line fix that only invloves changing case.
>
> You are missing the point: QuickForm *is* PHP5 compatible. We are talking about
> incompatibility with third-party code, I am insisting that this code should be
> fixed since it may be incompatible with more PEAR packages, my opponents insist
> that QuickForm should be "fixed", but this leads to "fixing" of all these
> other
> packages.
>
No, Alexey, you are missing the point. __autoload() is being called
for a class which exists. This *may* be a PHP bug but regardless a
simple bug fix to the HTML_QF code will fix this problem with no side
effects. This is not a discussion of how viable the bug reporter's
code is.
I am not your opponent and I'm surprised that you should see it this
way. We're all PEAR developers and we are supposed to be working
together.
And again, saying that it's *too much work* to fix all of the other
packages is not only incorrect, it does not pertain to this discussion
in the slightest.
> > Also the initial comment of "bullshit" makes me think there is some sort
> > of hate for this user going on, and thats really not the type of thing
> > that should be happening in PEAR.
>
> The initial comment of "bullshit" is targeted only at the initial report saying
> the following:
>
> ==========
> The code in RuleRegistry.php at line 217 reads
>
> if (is_a($element, 'html_quickform_group')) {
>
> it should read
>
> if (is_a($element, 'HTML_QuickForm_group')) {
>
> otherwise it will always evaulate to false.
>
> ==========
>
> which is exactly that: bullshit.
>
No, it's simply incorrect. If the user words things wrong or is
misguided let them know, but *politely*.
--
Justin Patrin