Re: Comments on bugs marked bogus

Dear HTML_QuickForm maintainers and/or PEAR-QA, I would like to request that the QA team fixes bug number 3197 (http://pear.php.net/bugs/bug.php?id=3197) in the HTML_QuickForm package. The only maintainer to voice any opinion about this bug refuses to resolve the issue or provide any sound technical reasoning for not resolving the issue. Please take it upon yourselves to fix this issue and release a new version of the package. The issue has been known since January of 2005. From http://pear.php.net/pepr/pepr-proposal-show.php?id=60 "If any QA related issues are found in a package that QA has not been granted permission to change without consulting the maintainer,the QA team will file a bug report. If the issue remains unresolved for 1 month (2+1+1 weeks; see below), QA may fix it themselves." The current maintainer is recommending hackish fixes and supressing errors instead of fixing the current code. I would much prefer to keep my code clean and readable. If you cannot or will not resolve this issue please let me know. Thank you, Scott Mattocks Alexey Borzov wrote:

Hi, Scott Mattocks wrote:

BTW, the most obvious problem with brain-dead __autoload() implementation described by Scott in the bug report is the following. Consider: some package author would like to check for PEAR errors, but save the overhead of loading PEAR.php when there is no error, so he writes: if (is_a($returnValue, 'PEAR_Error')) {

    ...

} Now brain-dead __autoload() kicks in and immediately dies, for there is no PEAR/Error.php: PEAR_Error is defined in PEAR.php.

Now you are just being a jerk. You also aren't paying much attention to details. The implementation I provided uses include_once. The page will not die. It will just spit out a bunch of errors. The page will continue to load. Had I used require_once you may have a point, but since I am not brain-dead, I used include_once. You can read up on include_once here if you need to: http://us2.php.net/manual/en/function.include-once.php

Well, you can use the magic @ operator then and your brain-dead function will not spit out any errors! See how easy it is to fix? Now go and fix, quick!

Also, a developer should not write the example you provided. They should be using PEAR::isError().

This approach was actually promoted on this mailing list and there are several prominent packages using it. So unless you are willing to open a *really huge* can of worms I suggest you shut up now.

-- Scott Mattocks scott@crisscott.com http://www.crisscott.com http://pear.php.net/user/scottmattocks