Re: Comments on bugs marked bogus

From: Date: Wed, 27 Jul 2005 07:13:09 +0000
Subject: Re: Comments on bugs marked bogus
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-38953@lists.php.net to get a copy of this message
Alan Knowles wrote: >I think autoload will be fixed to allow failure - It's a known bug of >the autoload implementation .... The bug is not that it should allow failure. The bug is more that is_a() shouldn't IMO call __autoload(). >Saying that though, using Case sensitive names in is_a(), is a rather >trivial change.. It's not as trivial as just changing one character in HTML_QuickForm. is_a() is used all over the place in other packages too. Before going any further, I think we need a small RFC about using __autoload(), is_a(), get_class() and all these functions that are related, in PEAR with PHP5. I suggest someone from the QA team looks after it, if they have some time. Then, as they did for the get_class() issue before, they could send a mail to package maintainers with the issues they found. Then, if the issue is not fixed within a given amount of time, they fix it themselves (and try not to break anything :) ). Alexey has one point with PEAR_Error. This should be fixed first. We also have an HTML_QuickForm_Error object, and like with PEAR, it is bundled in the same file as HTML_QuickForm. __autoload() will force us to use one file per class. IMO, this is silly, especially knowing that the biggest performance issue with PHP AFAIK is related to seeking files. But I don't want to fight windmills. So the question really is whether we want to allow the use of __autoload() with PHP knowing that, like magic_quotes, it is not a good practice, or if we simply don't care. This decision will have consequences on at least 50% of our packages, especially the big ones. The issue in HTML_QuickForm will be fixed when the RFC will be proposed and approved by all. Bertrand Mansion Mamasam

« previous php.pear.dev (#38953) next »