Re: Comments on bugs marked bogus
| From: | Justin Patrin | Date: | Tue, 26 Jul 2005 20:44:52 +0000 |
| Subject: | Re: Comments on bugs marked bogus | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-38936@lists.php.net to get a copy of this message | ||
On 7/26/05, Alexey Borzov <borz_off@cs.msu.su> wrote:
> Hi,
>
> Justin Patrin wrote:
> >>>>Also, a developer should not write the example you provided. They
> >>>>should be using PEAR::isError().
> >>>
> >>>
> >>>This approach was actually promoted on this mailing list and there are
> >>>several prominent packages using it. So unless you are willing to open a
> >>>*really huge* can of worms I suggest you shut up now.
> >>
> >>And I have promoted the use of PEAR::isError() on this list as well and
> >>I am willing to open this can of worms.
> >
> > I agree.
>
> Me too!
>
> OK, HTML_Template_Flexy uses is_a($foo, 'PEAR_Error') to check for errors..
>
> Lukas' own MDB uses is_a($whatever, 'mdb_common') with the "wrong"
> case.
>
> So the question is: is it easier to invest a *considerable* amount of time into
> "fixing" the packages to make them usable for stupid one-liner __autoload() or
> just add a note to the manual stating not to touch PEAR classes in __autoload()
> at all?
>
>
Please don't change the subject. This thread is about *your* package
and a *single line fix* in that package. Bug reports can be opened for
the others as well should they be needed.
--
Justin Patrin