Re: Comments on bugs marked bogus
| From: | Bertrand Mansion | Date: | Wed, 27 Jul 2005 16:48:21 +0000 |
| Subject: | Re: Comments on bugs marked bogus | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-38975@lists.php.net to get a copy of this message | ||
Scott Mattocks wrote:
>Pierre-Alain Joye wrote:
>
>> Well, I do not like autoload (too magic for me, and has never
>> worked well). But besides this problem and only about this one line
>> fix, we already discussed the needs to write class names, that
>> means case sensitive.
>>
>> The discussions about autoload can be good (will not change my mind
>> about it though) but this fix is easy and can be done now.
>
>I agree completely. The issue here is not whether or not autoload is a
>good idea. I know the pros and cons of autoload and I have decided to
>use it. My use of the function has no bearing on whether or not the
>issue in QF should be changed. The real issue here is (and no offense
>inteded to whomever wrote the code) that the code is just lazy. The only
>excuse for not using the proper case in the name is that the developer
>was lazy. It is poor coding practice to use 'html_quickform_group' when
>the classname is 'HTML_QuickForm_group'.
The only poor coding practice I see is trying to enforce case-sensitivity in a
case-insensitive language, and this is probably found in your __autoload() code.
>An RFC about the use of autoload is not the solution here. The solution
>is to make the code cleaner in HTML_QuickForm_RuleRegistry.php.
We won't fix this before an RFC about how to deal with __autoload() and PEAR is
written and approved. This is the decision of the lazy maintainers of
HTML_QuickForm. Now, if you are not lazy, just write it.
Bertrand Mansion
Mamasam